objmem: prevent calling audio_RemoveObj() from the destructors of in-game objects
#4033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManManson
force-pushed
the
fix-audio-remove-obj-segfaults
branch
from
cbba9a9 to
e3bd297
Compare
|
Adjusted the code to compile in C++14 mode + fixed potential use-after-move in |
ManManson
force-pushed
the
fix-audio-remove-obj-segfaults
branch
3 times, most recently
from
8aec60a to
090a732
Compare
…-game objects The call to `audio_RemoveObj` inside the destructors of `SIMPLE_OBJECT`, `DROID`, `STRUCTURE`, `FEATURE` and `PROJECTILE` classes can possibly invoke undefined behavior if the warzone process is being forcefully shut down. The reason for this is that by the time a given game object is being destroyed, chances are that the static objects from the audio code, which are being accessed by the `audio_RemoveObj()`, can already be destroyed (due to the inverse of the [Static initialization order fiasco](https://en.cppreference.com/w/cpp/language/siof)). Signed-off-by: Pavel Solodovnikov <[email protected]>
ManManson
force-pushed
the
fix-audio-remove-obj-segfaults
branch
from
090a732 to
97fc9e5
Compare
past-due
approved these changes
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to
audio_RemoveObjinside the destructors ofSIMPLE_OBJECT,DROID,STRUCTURE,FEATUREandPROJECTILEclasses can possibly invoke undefined behavior if the warzone process is being forcefully shut down (either by us, the user or some other third-party code, like X11 in case of linux).The reason for this is that by the time a given game object is being destroyed, chances are that the static objects from the audio code, which are being accessed by the
audio_RemoveObj(), can already be destroyed (due to the inverse of the Static initialization order fiasco).Signed-off-by: Pavel Solodovnikov [email protected]